[mp3togo] Re: mp3togo

[sim]

On 5/17/06, Justus Pendleton <justus at ryoohki.net> wrote:
> Here's my first patch :)
>
> I'm far from a distutils expert but I think you should use scripts
> instead of data for installing mp3togo in setup.py. That way it isn't
> hard coded to go in /usr/bin. That way if someone -- like, say, me -- is
> using virtual python and the correct directory is $HOME/bin it'll be
> used instead.
>
>
> Common subdirectories: mp3togo-0.3.0/bin and mp3togo-src/bin
> Only in mp3togo-src: build
> Common subdirectories: mp3togo-0.3.0/debian and mp3togo-src/debian
> Common subdirectories: mp3togo-0.3.0/mp3togo and mp3togo-src/mp3togo
> diff -u mp3togo-0.3.0/setup.py mp3togo-src/setup.py
> --- mp3togo-0.3.0/setup.py      2006-05-14 15:23:15.000000000 -0600
> +++ mp3togo-src/setup.py        2006-05-17 15:25:41.000000000 -0600
> @@ -68,7 +68,7 @@
>  The package installs a command line executable named mp3togo
>  in /usr/bin, for command line options, run `mp3togo --help`.""",
>        packages = ["mp3togo"],
> -         data_files = [('/usr/bin', ['bin/mp3togo'])],
> +          scripts = ['bin/mp3togo'],
>           classifiers = [
>             'Development Status :: 4 - Beta',
>                 'Environment :: Console',
> Common subdirectories: mp3togo-0.3.0/test and mp3togo-src/test
>
>
>

Thanks Justus,
I appreciate the patch, that exact change has been made to the file.

This problem was also pointed out by Christopher Arndt. It's a problem
if you need to install in /usr/local/bin as well. It was fixed in
0.3.1

I fixed a buggy bug fix this afternoon and posted 0.3.2

I have also started a mailing list for mp3togo, you can subscribe to
it through this page:
http://puddle.ca/cgi-bin/mailman/listinfo/mp3togo

Thanks again for the patch,

-- 
sim